[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 14/13] migration: Initialize and cleanup decompression in migr
From: |
Lukas Straub |
Subject: |
[PATCH v2 14/13] migration: Initialize and cleanup decompression in migration.c |
Date: |
Thu, 20 Apr 2023 11:59:50 +0200 |
This fixes compress with colo.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
Oops, this one slipped trough
migration/migration.c | 9 +++++++++
migration/ram.c | 5 -----
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index bda4789193..e7d082a208 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -26,6 +26,7 @@
#include "sysemu/cpu-throttle.h"
#include "rdma.h"
#include "ram.h"
+#include "ram-compress.h"
#include "migration/global_state.h"
#include "migration/misc.h"
#include "migration.h"
@@ -316,6 +317,7 @@ void migration_incoming_state_destroy(void)
struct MigrationIncomingState *mis = migration_incoming_get_current();
multifd_load_cleanup();
+ compress_threads_load_cleanup();
if (mis->to_src_file) {
/* Tell source that we are done */
@@ -598,6 +600,12 @@ process_incoming_migration_co(void *opaque)
Error *local_err = NULL;
assert(mis->from_src_file);
+
+ if (compress_threads_load_setup(mis->from_src_file)) {
+ error_report("Failed to setup decompress threads");
+ goto fail;
+ }
+
mis->migration_incoming_co = qemu_coroutine_self();
mis->largest_page_size = qemu_ram_pagesize_largest();
postcopy_state_set(POSTCOPY_INCOMING_NONE);
@@ -663,6 +671,7 @@ fail:
qemu_fclose(mis->from_src_file);
multifd_load_cleanup();
+ compress_threads_load_cleanup();
exit(EXIT_FAILURE);
}
diff --git a/migration/ram.c b/migration/ram.c
index ccfedf4fb5..344f326065 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3560,10 +3560,6 @@ void colo_release_ram_cache(void)
*/
static int ram_load_setup(QEMUFile *f, void *opaque)
{
- if (compress_threads_load_setup(f)) {
- return -1;
- }
-
xbzrle_load_setup();
ramblock_recv_map_init();
@@ -3579,7 +3575,6 @@ static int ram_load_cleanup(void *opaque)
}
xbzrle_load_cleanup();
- compress_threads_load_cleanup();
RAMBLOCK_FOREACH_NOT_IGNORED(rb) {
g_free(rb->receivedmap);
--
2.40.0
pgpR9sq1sDJaa.pgp
Description: OpenPGP digital signature
- Re: [PATCH v2 07/13] ram.c: Remove last ram.c dependency from the core compress code, (continued)
- [PATCH v2 09/13] ram.c: Move core compression code into its own file, Lukas Straub, 2023/04/20
- [PATCH v2 10/13] ram.c: Remove whitespace (squash with previous patch), Lukas Straub, 2023/04/20
- [PATCH v2 12/13] ram compress: Assert that the file buffer matches the result, Lukas Straub, 2023/04/20
- [PATCH v2 13/13] ram-compress.c: Make target independent, Lukas Straub, 2023/04/20
- [PATCH v2 11/13] ram.c: Move core decompression code into its own file, Lukas Straub, 2023/04/20
- [PATCH v2 14/13] migration: Initialize and cleanup decompression in migration.c,
Lukas Straub <=