qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/13] include: attempt to document device_class_set_props


From: Mark Cave-Ayland
Subject: Re: [PATCH v2 01/13] include: attempt to document device_class_set_props
Date: Thu, 20 Apr 2023 10:21:02 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 18/04/2023 17:21, Alex Bennée wrote:

I'm still not sure how I achieve by use case of the parent class
defining the following properties:

   static Property vud_properties[] = {
       DEFINE_PROP_CHR("chardev", VHostUserDevice, chardev),
       DEFINE_PROP_UINT16("id", VHostUserDevice, id, 0),
       DEFINE_PROP_UINT32("num_vqs", VHostUserDevice, num_vqs, 1),
       DEFINE_PROP_END_OF_LIST(),
   };

But for the specialisation of the class I want the id to default to
the actual device id, e.g.:

   static Property vu_rng_properties[] = {
       DEFINE_PROP_UINT16("id", VHostUserDevice, id, VIRTIO_ID_RNG),
       DEFINE_PROP_UINT32("num_vqs", VHostUserDevice, num_vqs, 1),
       DEFINE_PROP_END_OF_LIST(),
   };

And so far the API for doing that isn't super clear.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  include/hw/qdev-core.h | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index bd50ad5ee1..d4bbc30c92 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -776,6 +776,15 @@ BusState *sysbus_get_default(void);
  char *qdev_get_fw_dev_path(DeviceState *dev);
  char *qdev_get_own_fw_dev_path_from_handler(BusState *bus, DeviceState *dev);
+/**
+ * device_class_set_props(): add a set of properties to an device
+ * @dc: the parent DeviceClass all devices inherit
+ * @props: an array of properties, terminate by DEFINE_PROP_END_OF_LIST()
+ *
+ * This will add a set of properties to the object. It will fault if
+ * you attempt to add an existing property defined by a parent class.
+ * To modify an inherited property you need to use????
+ */
  void device_class_set_props(DeviceClass *dc, Property *props);
/**

Can we say that the use case description above is now obsolete with the introduction of the abstract VHOST_USER_BASE class (i.e. it was a modelling issue)? If so, I think the comment is good, except that the last sentence can be removed.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]