Re: [PATCH v2 11/41] tests/avocado: Remove test_igb_nomsi_kvm

[Thomas Huth]

On 20/04/2023 07.46, Akihiko Odaki wrote:
> It is unlikely to find more bugs with KVM so remove test_igb_nomsi_kvm
> to save time to run it.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   tests/avocado/netdev-ethtool.py | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/tests/avocado/netdev-ethtool.py b/tests/avocado/netdev-ethtool.py
> index 8de118e313..6da800f62b 100644
> --- a/tests/avocado/netdev-ethtool.py
> +++ b/tests/avocado/netdev-ethtool.py
> @@ -29,7 +29,7 @@ def get_asset(self, name, sha1):
>           # URL into a unique one
>           return self.fetch_asset(name=name, locations=(url), asset_hash=sha1)
>   
> -    def common_test_code(self, netdev, extra_args=None, kvm=False):
> +    def common_test_code(self, netdev, extra_args=None):
>   
>           # This custom kernel has drivers for all the supported network
>           # devices we can emulate in QEMU
> @@ -57,9 +57,6 @@ def common_test_code(self, netdev, extra_args=None, 
> kvm=False):
>                            '-drive', drive,
>                            '-device', netdev)
>   
> -        if kvm:
> -            self.vm.add_args('-accel', 'kvm')
> -
>           self.vm.set_console(console_index=0)
>           self.vm.launch()
>   
> @@ -86,13 +83,6 @@ def test_igb_nomsi(self):
>           """
>           self.common_test_code("igb", "pci=nomsi")
>   
> -    def test_igb_nomsi_kvm(self):
> -        """
> -        :avocado: tags=device:igb
> -        """
> -        self.require_accelerator('kvm')
> -        self.common_test_code("igb", "pci=nomsi", True)

Reviewed-by: Thomas Huth <thuth@redhat.com>