Re: [PATCH v2 2/4] vl.c: Create late backends before migration object

[David Hildenbrand]

On 19.04.23 18:17, Peter Xu wrote:
> The migration object may want to check against different types of memory
> when initialized.  Delay the creation to be after late backends.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   softmmu/vl.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index ea20b23e4c..ad394b402f 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -3583,14 +3583,19 @@ void qemu_init(int argc, char **argv)
>                        machine_class->name, machine_class->deprecation_reason);
>       }
>   
> +    /*
> +     * Create backends before creating migration objects, so that it can
> +     * check against compatibilities on the backend memories (e.g. postcopy
> +     * over memory-backend-file objects).
> +     */
> +    qemu_create_late_backends();
> +
>       /*
>        * Note: creates a QOM object, must run only after global and
>        * compat properties have been set up.
>        */
>       migration_object_init();
>   
> -    qemu_create_late_backends();
> -
>       /* parse features once if machine provides default cpu_type */
>       current_machine->cpu_type = machine_class->default_cpu_type;
>       if (cpu_option) {

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb