Re: [PATCH 0/2] tests/migration: Fix migration-test slowdown

[Thomas Huth]

On 18/04/2023 13.42, Juan Quintela wrote:
> Thomas Huth <thuth@redhat.com> wrote:
> > On 12/04/2023 16.19, Juan Quintela wrote:
> > > Since commit:
> > > commit 1bfc8dde505f1e6a92697c52aa9b09e81b54c78f
> > > Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > > Date:   Mon Mar 6 15:26:12 2023 +0000
> > >       tests/migration: Tweek auto converge limits check
> > >       Thomas found an autoconverge test failure where the
> > >       migration completed before the autoconverge had kicked in.
> > >       [...]
> > > migration-test has become very slow.
> > > On my laptop, before that commit migration-test takes 2min10seconds
> > > After that commit, it takes around 11minutes
> > > We can't revert it because it fixes a real problem when the host
> > > machine is overloaded.  See the comment on test_migrate_auto_converge().
> >
> > Thanks, your patches decrease the time to run the migration-test from
> > 16 minutes down to 5 minutes on my system, that's a great improvement,
> > indeed!
> >
> > Tested-by: Thomas Huth <thuth@redhat.com>
>
> Thanks
>
> > (though 5 minutes are still quite a lot for qtests ... maybe some
> > other parts could be moved to only run with g_test_slow() ?)
>
> Hi
>
> Could you gime the output of:
>
> time for i in $(./tests/qtest/migration-test -l | grep "^/"); do echo $i; time 
> ./tests/qtest/migration-test -p $i; done
>
> To see what tests are taking so long on your system?
>
> On my system (i9900K processor, i.e. not the latest) and auto_converge
> moved to slow the total of the tests take a bit more than 1 minute.

This is with both of your patches applied:

/x86_64/migration/bad_dest
/x86_64/migration/bad_dest: OK

real    0m0,342s
user    0m0,123s
sys     0m0,088s
/x86_64/migration/fd_proto
/x86_64/migration/fd_proto: OK

real    0m1,135s
user    0m0,730s
sys     0m0,514s
/x86_64/migration/validate_uuid
/x86_64/migration/validate_uuid: OK

real    0m0,519s
user    0m0,379s
sys     0m0,230s
/x86_64/migration/validate_uuid_error
/x86_64/migration/validate_uuid_error: OK

real    0m0,275s
user    0m0,145s
sys     0m0,114s
/x86_64/migration/validate_uuid_src_not_set
/x86_64/migration/validate_uuid_src_not_set: OK

real    0m0,514s
user    0m0,377s
sys     0m0,225s
/x86_64/migration/validate_uuid_dst_not_set
/x86_64/migration/validate_uuid_dst_not_set: OK

real    0m0,519s
user    0m0,392s
sys     0m0,220s
/x86_64/migration/dirty_ring
/x86_64/migration/dirty_ring: OK

real    0m1,079s
user    0m0,613s
sys     0m0,532s
/x86_64/migration/vcpu_dirty_limit
/x86_64/migration/vcpu_dirty_limit: OK

real    0m6,308s
user    0m4,025s
sys     0m1,224s
/x86_64/migration/postcopy/plain
/x86_64/migration/postcopy/plain: OK

real    0m35,446s
user    0m47,208s
sys     0m11,828s
/x86_64/migration/postcopy/recovery/plain
/x86_64/migration/postcopy/recovery/plain: OK

real    0m34,707s
user    0m46,357s
sys     0m11,366s
/x86_64/migration/postcopy/recovery/tls/psk
/x86_64/migration/postcopy/recovery/tls/psk: OK

real    0m33,052s
user    0m46,539s
sys     0m11,537s
/x86_64/migration/postcopy/preempt/plain
/x86_64/migration/postcopy/preempt/plain: OK

real    0m35,107s
user    0m46,556s
sys     0m11,755s
/x86_64/migration/postcopy/preempt/recovery/plain
/x86_64/migration/postcopy/preempt/recovery/plain: OK

real    0m35,329s
user    0m46,951s
sys     0m11,529s
/x86_64/migration/postcopy/preempt/recovery/tls/psk
/x86_64/migration/postcopy/preempt/recovery/tls/psk: OK

real    0m36,237s
user    0m51,450s
sys     0m12,419s
/x86_64/migration/postcopy/preempt/tls/psk
/x86_64/migration/postcopy/preempt/tls/psk: OK

real    0m35,033s
user    0m49,244s
sys     0m12,123s
/x86_64/migration/postcopy/tls/psk
/x86_64/migration/postcopy/tls/psk: OK

real    0m36,097s
user    0m50,873s
sys     0m12,569s
/x86_64/migration/precopy/unix/plain
/x86_64/migration/precopy/unix/plain: OK

real    0m1,034s
user    0m0,654s
sys     0m0,463s
/x86_64/migration/precopy/unix/xbzrle
/x86_64/migration/precopy/unix/xbzrle: OK

real    0m1,119s
user    0m0,740s
sys     0m0,499s
/x86_64/migration/precopy/unix/tls/psk
/x86_64/migration/precopy/unix/tls/psk: OK

real    0m3,555s
user    0m5,448s
sys     0m0,655s
/x86_64/migration/precopy/unix/tls/x509/default-host
/x86_64/migration/precopy/unix/tls/x509/default-host: OK

real    0m1,022s
user    0m1,664s
sys     0m0,112s
/x86_64/migration/precopy/unix/tls/x509/override-host
/x86_64/migration/precopy/unix/tls/x509/override-host: OK

real    0m1,841s
user    0m1,921s
sys     0m0,739s
/x86_64/migration/precopy/tcp/plain
/x86_64/migration/precopy/tcp/plain: OK

real    0m1,241s
user    0m0,859s
sys     0m0,584s
/x86_64/migration/precopy/tcp/tls/psk/match
/x86_64/migration/precopy/tcp/tls/psk/match: OK

real    0m2,114s
user    0m2,628s
sys     0m0,613s
/x86_64/migration/precopy/tcp/tls/psk/mismatch
/x86_64/migration/precopy/tcp/tls/psk/mismatch: OK

real    0m0,575s
user    0m0,554s
sys     0m0,116s
/x86_64/migration/precopy/tcp/tls/x509/default-host
/x86_64/migration/precopy/tcp/tls/x509/default-host: OK

real    0m1,538s
user    0m1,460s
sys     0m0,608s
/x86_64/migration/precopy/tcp/tls/x509/override-host
/x86_64/migration/precopy/tcp/tls/x509/override-host: OK

real    0m1,825s
user    0m1,915s
sys     0m0,703s
/x86_64/migration/precopy/tcp/tls/x509/mismatch-host
/x86_64/migration/precopy/tcp/tls/x509/mismatch-host: OK

real    0m0,961s
user    0m1,430s
sys     0m0,111s
/x86_64/migration/precopy/tcp/tls/x509/friendly-client
/x86_64/migration/precopy/tcp/tls/x509/friendly-client: OK

real    0m1,806s
user    0m1,897s
sys     0m0,679s
/x86_64/migration/precopy/tcp/tls/x509/hostile-client
/x86_64/migration/precopy/tcp/tls/x509/hostile-client: OK

real    0m0,645s
user    0m0,614s
sys     0m0,136s
/x86_64/migration/precopy/tcp/tls/x509/allow-anon-client
/x86_64/migration/precopy/tcp/tls/x509/allow-anon-client: OK

real    0m2,204s
user    0m2,695s
sys     0m0,667s
/x86_64/migration/precopy/tcp/tls/x509/reject-anon-client
/x86_64/migration/precopy/tcp/tls/x509/reject-anon-client: OK

real    0m1,530s
user    0m2,360s
sys     0m0,156s
/x86_64/migration/multifd/tcp/plain/none
/x86_64/migration/multifd/tcp/plain/none: OK

real    0m1,055s
user    0m0,647s
sys     0m0,592s
/x86_64/migration/multifd/tcp/plain/zlib
/x86_64/migration/multifd/tcp/plain/zlib: OK

real    0m1,144s
user    0m1,763s
sys     0m0,437s
/x86_64/migration/multifd/tcp/plain/zstd
/x86_64/migration/multifd/tcp/plain/zstd: OK

real    0m1,073s
user    0m0,999s
sys     0m0,537s
/x86_64/migration/multifd/tcp/tls/psk/match
/x86_64/migration/multifd/tcp/tls/psk/match: OK

real    0m1,453s
user    0m2,475s
sys     0m0,704s
/x86_64/migration/multifd/tcp/tls/psk/mismatch
/x86_64/migration/multifd/tcp/tls/psk/mismatch: OK

real    0m0,905s
user    0m1,256s
sys     0m0,106s
/x86_64/migration/multifd/tcp/tls/x509/default-host
/x86_64/migration/multifd/tcp/tls/x509/default-host: OK

real    0m3,761s
user    0m5,874s
sys     0m0,985s
/x86_64/migration/multifd/tcp/tls/x509/override-host
/x86_64/migration/multifd/tcp/tls/x509/override-host: OK

real    0m3,238s
user    0m4,794s
sys     0m0,998s
/x86_64/migration/multifd/tcp/tls/x509/mismatch-host
/x86_64/migration/multifd/tcp/tls/x509/mismatch-host: OK

real    0m0,851s
user    0m1,007s
sys     0m0,120s
/x86_64/migration/multifd/tcp/tls/x509/allow-anon-client
/x86_64/migration/multifd/tcp/tls/x509/allow-anon-client: OK

real    0m2,607s
user    0m3,530s
sys     0m1,013s
/x86_64/migration/multifd/tcp/tls/x509/reject-anon-client
/x86_64/migration/multifd/tcp/tls/x509/reject-anon-client: OK

real    0m1,915s
user    0m3,223s
sys     0m0,180s

real    5m32,733s
user    7m24,380s
sys     1m50,801s

 Thomas