qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] tests: libvirt-ci: Update to commit '51dad419'


From: Paolo Bonzini
Subject: Re: [PATCH v2 1/2] tests: libvirt-ci: Update to commit '51dad419'
Date: Tue, 18 Apr 2023 11:05:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0

On 4/17/23 14:46, Peter Krempa wrote:
Update to commit which has fixes needed for OpenSUSE 15.4 and
re-generate output files.

Signed-off-by: Peter Krempa<pkrempa@redhat.com>
---
  .gitlab-ci.d/cirrus/freebsd-12.vars           |  16 ++
  .gitlab-ci.d/cirrus/freebsd-13.vars           |  16 ++
  .gitlab-ci.d/cirrus/macos-12.vars             |  16 ++
  tests/docker/dockerfiles/alpine.docker        | 127 +++++++++++++

Oops, I missed that '51dad419' is buggy and the next commit (2fa24dce8b) is
needed instead:

    commit 2fa24dce8bc2d0d57b02b111dbdbd24e25d4ae95
    Author: Erik Skultety <eskultet@redhat.com>
    Date:   Wed Apr 5 15:43:55 2023 +0200

    lcitool: __main__: Prevent running main() on import
When commit f0cc11e3f introduced the module, it did it so that:
    1) it complies with PEP 517 [1]
    2) lcitool could be executed as a Python module
The implementation is based on having a __main__.py module which Python
    can automatically import. The problem is that when the main function is
    imported from the module from within the automatic executable wrapper
    created when the package is installed, it executes the whole module on
    import (standard behaviour). At the end of the module there's an
    unguarded call to the main() function.
    Fix this with the '__name__ == "__main__"' idiom.
Fixes: f0cc11e3f [1] https://peps.python.org/pep-0517/ Signed-off-by: Erik Skultety <eskultet@redhat.com>

I adjusted the submodule and rerun tests/lcitool/refresh.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]