Re: [PATCH] virtio: i2c: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX

[Viresh Kumar]

On 17-04-23, 09:36, Philippe Mathieu-Daudé wrote:
> On 17/4/23 08:02, Viresh Kumar wrote:
> > Since the driver doesn't support interrupts, we must return early when
> > index is set to VIRTIO_CONFIG_IRQ_IDX.
> > 
> > Fixes: 544f0278afca ("virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX")
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> >   hw/virtio/vhost-user-i2c.c | 20 ++++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> > 
> > diff --git a/hw/virtio/vhost-user-i2c.c b/hw/virtio/vhost-user-i2c.c
> > index 60eaf0d95be0..45100a24953c 100644
> > --- a/hw/virtio/vhost-user-i2c.c
> > +++ b/hw/virtio/vhost-user-i2c.c
> > @@ -128,6 +128,16 @@ static void vu_i2c_guest_notifier_mask(VirtIODevice 
> > *vdev, int idx, bool mask)
> >   {
> >       VHostUserI2C *i2c = VHOST_USER_I2C(vdev);
> > +    /*
> > +     * Add the check for configure interrupt, Use VIRTIO_CONFIG_IRQ_IDX -1
> > +     * as the Marco of configure interrupt's IDX, If this driver does not
> 
> Copy/paste of pre-existing comment, still I wonder who is "the Marco of
> configure" :P
> 
> > +     * support, the function will return
> > +     */

Yeah the comment could be improved, I didn't touch it as it was
written this way for many drivers :)

Maybe a simple comment like is all we need:

/*
 * We don't support interrupts, return early if index is set to
 * VIRTIO_CONFIG_IRQ_IDX.
 */

-- 
viresh