Re: [PATCH 1/2] travis.yml: Add missing clang-10 package to the 'Clang (disable-tcg)' job

[Thomas Huth]

On 14/04/2023 23.06, Vaibhav Jain wrote:
> Since commit 74a1b256d775("configure: Bump minimum Clang version to 10.0") qemu
> needs Clang version 10.0 as the minimum version to build qemu with
> Clang. However 'focal' ships by default with Clang version 7.0.0 which causes an
> error while executing the 'Clang (disable-tcg)' travis job of the form below:
>
> <snip>
> $clang --version
>
> clang version 7.0.0 (tags/RELEASE_700/final)
>
> <snip>
>   ERROR: You need at least GCC v7.4 or Clang v10.0 (or XCode Clang v12.0)
>
>   # QEMU configure log Fri 14 Apr 2023 03:48:22 PM UTC
>
>   # Configured with: '../configure' '--disable-docs' '--disable-tools'
>   '--disable-containers' '--disable-tcg' '--enable-kvm' '--disable-tools'
>   '--enable-fdt=system' '--host-cc=clang' '--cxx=clang++'
>
> Fix this by adding 'clang-10' to the 'apt_packages' section of the "[s390x]
> Clang (disable-tcg)" job and updating the compiler to 'clang-10'.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> ---
>   .travis.yml | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index cf088ba4cf..11894eb810 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -243,7 +243,7 @@ jobs:
>       - name: "[s390x] Clang (disable-tcg)"
>         arch: s390x
>         dist: focal
> -      compiler: clang
> +      compiler: clang-10
>         addons:
>           apt_packages:
>             - libaio-dev
> @@ -269,6 +269,7 @@ jobs:
>             - libvdeplug-dev
>             - libvte-2.91-dev
>             - ninja-build
> +          - clang-10

Are you sure about this one? It works for me:

 https://app.travis-ci.com/github/huth/qemu/jobs/600292740

Also, Clang v10 seems to be the default version in Focal:

 https://packages.ubuntu.com/focal/clang

So how did you end up with Clang v7.0 in your run?

 Thomas


PS: We should maybe rather update the Travis jobs to Jammy nowadays instead.