|
From: | Harsh Prateek Bora |
Subject: | Re: [PATCH 3/5] ppc: spapr: assert early rather late in h_enter_nested() |
Date: | Mon, 17 Apr 2023 12:45:44 +0530 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 |
On 4/14/23 17:25, Fabiano Rosas wrote:
Yes, I could rephrase the commit log, but I am okay with your below suggestion for now.Harsh Prateek Bora <harshpb@linux.ibm.com> writes:Currently, it asserts very late in the code flow if lpid is already initialized.That's not about initializing. It is about making sure the LPIDR is 0. Which has a specific meaning according to the ISA.
Ideally, it should assert in the beginning if that is the case. This patch brings assert check in the beginning alongwith the related initialization.Maybe just leave it where it is. There's not much to gain from moving this.
Will drop this change for now as value-add is relatively lesser.
[Prev in Thread] | Current Thread | [Next in Thread] |