[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 05/40] igb: Do not require CTRL.VME for tx VLAN tagging
From: |
Sriram Yagnaraman |
Subject: |
RE: [PATCH 05/40] igb: Do not require CTRL.VME for tx VLAN tagging |
Date: |
Sat, 15 Apr 2023 19:08:29 +0000 |
> -----Original Message-----
> From: Akihiko Odaki <akihiko.odaki@daynix.com>
> Sent: Friday, 14 April 2023 13:37
> Cc: Sriram Yagnaraman <sriram.yagnaraman@est.tech>; Jason Wang
> <jasowang@redhat.com>; Dmitry Fleytman <dmitry.fleytman@gmail.com>;
> Michael S. Tsirkin <mst@redhat.com>; Alex Bennée <alex.bennee@linaro.org>;
> Philippe Mathieu-Daudé <philmd@linaro.org>; Thomas Huth
> <thuth@redhat.com>; Wainer dos Santos Moschetta
> <wainersm@redhat.com>; Beraldo Leal <bleal@redhat.com>; Cleber Rosa
> <crosa@redhat.com>; Laurent Vivier <lvivier@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>; qemu-devel@nongnu.org; Akihiko Odaki
> <akihiko.odaki@daynix.com>
> Subject: [PATCH 05/40] igb: Do not require CTRL.VME for tx VLAN tagging
>
> While the datasheet of e1000e says it checks CTRL.VME for tx VLAN tagging,
> igb's datasheet has no such statements. It also says for
> "CTRL.VLE":
> > This register only affects the VLAN Strip in Rx it does not have any
> > influence in the Tx path in the 82576.
> (Appendix A. Changes from the 82575)
>
> There is no "CTRL.VLE" so it is more likely that it is a mistake of CTRL.VME.
>
> Fixes: fba7c3b788 ("igb: respect VMVIR and VMOLR for VLAN")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> hw/net/igb_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
- [PATCH 01/40] hw/net/net_tx_pkt: Decouple from PCI, (continued)
- [PATCH 03/40] igb: Fix Rx packet type encoding, Akihiko Odaki, 2023/04/14
- [PATCH 05/40] igb: Do not require CTRL.VME for tx VLAN tagging, Akihiko Odaki, 2023/04/14
- RE: [PATCH 05/40] igb: Do not require CTRL.VME for tx VLAN tagging,
Sriram Yagnaraman <=
- [PATCH 06/40] net/net_rx_pkt: Use iovec for net_rx_pkt_set_protocols(), Akihiko Odaki, 2023/04/14
- [PATCH 07/40] e1000e: Always copy ethernet header, Akihiko Odaki, 2023/04/14
- [PATCH 08/40] igb: Always copy ethernet header, Akihiko Odaki, 2023/04/14
- [PATCH 09/40] Fix references to igb Avocado test, Akihiko Odaki, 2023/04/14
- [PATCH 11/40] tests/avocado: Remove test_igb_nomsi_kvm, Akihiko Odaki, 2023/04/14
- [PATCH 10/40] tests/avocado: Remove unused imports, Akihiko Odaki, 2023/04/14