Re: [PATCH 0/3] SDL2 usability fixes

[BALATON Zoltan]

On Fri, 14 Apr 2023, Bernhard Beschow wrote:
> Am 14. April 2023 06:53:18 UTC schrieb "Volker Rümelin" <vr_qemu@t-online.de>:
> > Am 13.04.23 um 22:43 schrieb Bernhard Beschow:
> > > Am 13. April 2023 17:54:34 UTC schrieb "Volker Rümelin" <vr_qemu@t-online.de>:
> > > > > I'm trying to use QEMU on Windows hosts for fun and for profit. While the GTK
> > > > > GUI doesn't seem to support OpenGL under Windows the SDL2 GUI does. Hence I
> > > > > used the SDL2 GUI where I ran into several issues of which three are fixed in
> > > > > this series, which are:
> > > > >
> > > > > * Alt+Tab switches tasks on the host rather than in the guest in fullscreen mode
> > > > > * Alt+F4 closes QEMU rather than a graphical task in the guest
> > > > > * AltGr keyboard modifier isn't recognized by a Linux guest
> > > > >
> > > > > More information about each issue is provided in the patches.
> > > > >
> > > > > Bernhard Beschow (3):
> > > > >     ui/sdl2: Grab Alt+Tab also in fullscreen mode
> > > > >     ui/sdl2: Grab Alt+F4 also under Windows
> > > > >     ui/sdl2-input: Fix AltGr modifier on Windows hosts
> > > > >
> > > > >    ui/sdl2-input.c | 13 +++++++++++++
> > > > >    ui/sdl2.c       |  2 ++
> > > > >    2 files changed, 15 insertions(+)
> > > > Hi Bernhard,
> > > Hi Volker,
> > >
> > > > I don't think these patches are necessary. The AltGr key and the keyboard grab was fixed 
> > > > in 2020 with commit 830473455f ("ui/sdl2: fix handling of AltGr key on 
> > > > Windows") and a few commits before.
> > > Indeed, this patch addresses the AltGr issue. What I noticed in my case is that 
> > > the AltGr behavior is different, depending on whether the *guest* is in 
> > > graphics mode or not. Pressing AltGr in graphics mode issues two key modifiers 
> > > while only one is issued when the guest is in text mode. I'll recheck tomorrow 
> > > when I have access to a Windows host.
> >
> > Hi Bernhard,
>
> Hi Volker,
>
> > the AltGr behavior depends on the keyboard grab. The AltGr key works without 
> > keyboard grabbed and it doesn't with keyboard grabbed. That's a bug.
>
> Interesting. The keyboard is grabbed automatically for some reason when 
> the guest enters graphics mode. Together with what you describe this 
> could explain the difference in behavior I'm seeing.

Not sure how it works on Windows but keyboard grab may depend on the 
drivers or devices in the guest. I think using a usb-tablet may auto-grab 
mouse while using a mouse needs to click in the window to grab. Also not 
sure how this relates to keyboard at all so maybe this is not relevant 
here in which case sorry for the noise. I guess what I wanted to say is 
also check what command line you use (what input devices you VM has) and 
what guest side drivers you use that may have an effect (such as some 
vmware drivers could or maybe some other drivers). In any case first you 
should sync to make sure you're on the same page and testing the same 
thing to avoid some confusion. Sorry if this is not really helpful.

Regrads,
BALATON Zoltan