qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 02/10] tests: add python3-venv dependency


From: Philippe Mathieu-Daudé
Subject: Re: [RFC PATCH v2 02/10] tests: add python3-venv dependency
Date: Fri, 14 Apr 2023 16:17:28 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1

On 14/4/23 07:54, John Snow wrote:
Several debian-based tests need the python3-venv dependency as a
consequence of Debian debundling the "ensurepip" module normally
included with Python.

As mkvenv.py stands as of this commit, Debian requires EITHER:

(A) setuptools and pip, or
(B) ensurepip

mkvenv is a few seconds faster if you have setuptools and pip, so
developers should prefer the first requirement. For the purposes of CI,
the time-save is a wash; it's only a matter of who is responsible for
installing pip and when; the timing is about the same.

Arbitrarily, I chose adding ensurepip to the test configuration because
it is normally part of the Python stdlib, and always having it allows us
a more consistent cross-platform environment.

Signed-off-by: John Snow <jsnow@redhat.com>
---
  tests/docker/dockerfiles/debian-all-test-cross.docker | 3 ++-
  tests/docker/dockerfiles/debian-hexagon-cross.docker  | 3 ++-
  tests/docker/dockerfiles/debian-riscv64-cross.docker  | 3 ++-
  tests/docker/dockerfiles/debian-tricore-cross.docker  | 3 ++-
  4 files changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]