qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] ppc: spapr: cleanup cr get/store with helper routines.


From: Fabiano Rosas
Subject: Re: [PATCH 1/5] ppc: spapr: cleanup cr get/store with helper routines.
Date: Fri, 14 Apr 2023 08:40:37 -0300

Harsh Prateek Bora <harshpb@linux.ibm.com> writes:

A bit vague on the subject line. I would expect to see some mention to
nested at least.

> The bits in cr reg are grouped into eight 4-bit fields represented
> by env->crf[8] and the related calculations should be abstracted to
> keep the calling routines simpler to read. This is a step towards
> cleaning up the [h_enter|spapr_exit]_nested calls for better readability.
>
> Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]