[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: Initialize debug capabilities only once
From: |
Peter Maydell |
Subject: |
Re: [PATCH] target/arm: Initialize debug capabilities only once |
Date: |
Tue, 11 Apr 2023 15:43:42 +0100 |
On Wed, 5 Apr 2023 at 16:36, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> kvm_arm_init_debug() used to be called several times on a SMP system as
> kvm_arch_init_vcpu() calls it. Move the call to kvm_arch_init() to make
> sure it will be called only once; otherwise it will overwrite pointers
> to memory allocated with the previous call and leak it.
>
> Fixes: e4482ab7e3 ("target-arm: kvm - add support for HW assisted debug")
> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Supersedes: <20230405070244.23464-1-akihiko.odaki@daynix.com>
> ("[PATCH] target/arm: Check if debug is already initialized")
Oops, I was going through my to-review folder in a somewhat
random order and hadn't realized this was a v2 of that
other patch I just replied to.
Applied to target-arm.next for 8.1, thanks.
-- PMM