qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 21/42] tcg/aarch64: Rename ext to d_type in tcg_out_qemu_ld


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 21/42] tcg/aarch64: Rename ext to d_type in tcg_out_qemu_ld
Date: Tue, 11 Apr 2023 14:14:05 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1

On 8/4/23 04:42, Richard Henderson wrote:
The new name is slightly more descritive as "data type",
where "extend", despite the c type, sounds like a bool.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  tcg/aarch64/tcg-target.c.inc | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
index 4ec3cf3172..40122e1471 100644
--- a/tcg/aarch64/tcg-target.c.inc
+++ b/tcg/aarch64/tcg-target.c.inc
@@ -1851,7 +1851,7 @@ static void tcg_out_qemu_st_direct(TCGContext *s, MemOp 
memop,
  }
static void tcg_out_qemu_ld(TCGContext *s, TCGReg data_reg, TCGReg addr_reg,
-                            MemOpIdx oi, TCGType ext)
+                            MemOpIdx oi, TCGType d_type)

Since we have 'data_reg', can we use 'data_type'?

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]