Re: [PATCH 21/42] tcg/aarch64: Rename ext to d_type in tcg_out_qemu_ld

[Philippe Mathieu-Daudé]

On 8/4/23 04:42, Richard Henderson wrote:
> The new name is slightly more descritive as "data type",
> where "extend", despite the c type, sounds like a bool.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/aarch64/tcg-target.c.inc | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc
> index 4ec3cf3172..40122e1471 100644
> --- a/tcg/aarch64/tcg-target.c.inc
> +++ b/tcg/aarch64/tcg-target.c.inc
> @@ -1851,7 +1851,7 @@ static void tcg_out_qemu_st_direct(TCGContext *s, MemOp 
> memop,
>   }
>   
>   static void tcg_out_qemu_ld(TCGContext *s, TCGReg data_reg, TCGReg addr_reg,
> -                            MemOpIdx oi, TCGType ext)
> +                            MemOpIdx oi, TCGType d_type)

Since we have 'data_reg', can we use 'data_type'?

Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>