Re: [PULL 15/30] configure, meson: move some default-disabled options to meson_options.txt

[Peter Maydell]

On Tue, 15 Feb 2022 at 09:53, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> These do not depend on --with-default-features, so they become
> booleans in meson too.

Hi; I've just noticed what looks like an unintentional
change in this commit. The subject says it's dealing
with "default-disabled options"...

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

> diff --git a/configure b/configure
> index 1a15e2325e..5a4a642846 100755

> @@ -311,13 +309,11 @@ modules="no"
>  module_upgrades="no"
>  prefix="/usr/local"
>  qemu_suffix="qemu"
> -profiler="no"
>  softmmu="yes"
>  linux_user=""
>  bsd_user=""
>  pkgversion=""
>  pie=""
> -qom_cast_debug="yes"

...but qom_cast_debug is not default-disabled, it's default-enabled...

>  trace_backends="log"
>  trace_file="trace"
>  opengl="$default_feature"

> diff --git a/meson_options.txt b/meson_options.txt
> index 3bfaa77805..781e4d5170 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -242,3 +242,15 @@ option('qed', type: 'feature', value: 'auto',
>         description: 'qed image format support')
>  option('parallels', type: 'feature', value: 'auto',
>         description: 'parallels image format support')
> +option('block_drv_whitelist_in_tools', type: 'boolean', value: false,
> +       description: 'use block whitelist also in tools instead of only QEMU')
> +option('rng_none', type: 'boolean', value: false,
> +       description: 'dummy RNG, avoid using /dev/(u)random and getrandom()')
> +option('debug_mutex', type: 'boolean', value: false,
> +       description: 'mutex debugging support')
> +option('qom_cast_debug', type: 'boolean', value: false,
> +       description: 'cast debugging support')

...and so here we've accidentally inverted the default
so we aren't doing the QOM casting checks any more.

Spotted while looking at https://gitlab.com/qemu-project/qemu/-/issues/1586
where RedHat downstream found this because they happen to configure
with the option explicitly enabled.

I think we should fix the default back to what it was, but that
seems a bit risky for 8.0 at this point.

thanks
-- PMM