Re: riscv: g_assert for NULL predicate?

[Bin Meng]

On Wed, Apr 5, 2023 at 2:07 PM Alistair Francis <alistair23@gmail.com> wrote:
>
> On Mon, Apr 3, 2023 at 11:43 PM Wu, Fei <fei2.wu@intel.com> wrote:
> >
> > Recent commit 0ee342256af92 switches to g_assert() for the predicate()
> > NULL check from returning RISCV_EXCP_ILLEGAL_INST. Qemu doesn't have
> > predicate() for un-allocated CSRs, then a buggy userspace application
> > reads CSR such as 0x4 causes qemu to exit, I don't think it's expected.
>
> Hm.... That's not good. Userspace shouldn't be able to crash QEMU. I
> think we want to revert that patch then.
>
> @Bin Meng any thoughts?
>

Agree, I will send a patch for this.

Regards,
Bin