[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 01/19] bsd-user: Make print_* public
From: |
Warner Losh |
Subject: |
[PATCH v2 01/19] bsd-user: Make print_* public |
Date: |
Mon, 10 Apr 2023 12:20:38 -0600 |
Make these functions public. Due to coming restructuring, we'll need to
call these from *bsd/os-syscall.c. Add declarations to qemu.h.
Signed-off-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
bsd-user/qemu.h | 20 ++++++++++++++++++++
bsd-user/strace.c | 29 +++++++++++++----------------
2 files changed, 33 insertions(+), 16 deletions(-)
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 41d84e0b81b..22e16816a9e 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -211,6 +211,26 @@ print_openbsd_syscall(int num,
abi_long arg1, abi_long arg2, abi_long arg3,
abi_long arg4, abi_long arg5, abi_long arg6);
void print_openbsd_syscall_ret(int num, abi_long ret);
+void print_execve(const struct syscallname *name, abi_long arg1,
+ abi_long arg2, abi_long arg3, abi_long arg4,
+ abi_long arg5, abi_long arg6);
+void print_ioctl(const struct syscallname *name,
+ abi_long arg1, abi_long arg2, abi_long arg3,
+ abi_long arg4, abi_long arg5, abi_long arg6);
+void print_sysarch(const struct syscallname *name, abi_long arg1,
+ abi_long arg2, abi_long arg3, abi_long arg4,
+ abi_long arg5, abi_long arg6);
+void print_sysctl(const struct syscallname *name, abi_long arg1,
+ abi_long arg2, abi_long arg3, abi_long arg4,
+ abi_long arg5, abi_long arg6);
+void print_syscall(int num, const struct syscallname *scnames,
+ unsigned int nscnames, abi_long arg1, abi_long arg2,
+ abi_long arg3, abi_long arg4, abi_long arg5,
+ abi_long arg6);
+void print_syscall_ret(int num, abi_long ret,
+ const struct syscallname *scnames,
+ unsigned int nscnames);
+void print_syscall_ret_addr(const struct syscallname *name, abi_long ret);
/**
* print_taken_signal:
* @target_signum: target signal being taken
diff --git a/bsd-user/strace.c b/bsd-user/strace.c
index 96499751eb0..e45909b8688 100644
--- a/bsd-user/strace.c
+++ b/bsd-user/strace.c
@@ -49,7 +49,7 @@ print_raw_param(const char *fmt, abi_long param, int last)
gemu_log(format, param);
}
-static void print_sysctl(const struct syscallname *name, abi_long arg1,
+void print_sysctl(const struct syscallname *name, abi_long arg1,
abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5,
abi_long arg6)
{
@@ -71,9 +71,8 @@ static void print_sysctl(const struct syscallname *name,
abi_long arg1,
(uint32_t)arg2, arg3, arg4, arg5, arg6);
}
-static void print_execve(const struct syscallname *name, abi_long arg1,
- abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5,
- abi_long arg6)
+void print_execve(const struct syscallname *name, abi_long arg1, abi_long arg2,
+ abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6)
{
abi_ulong arg_ptr_addr;
char *s;
@@ -105,9 +104,8 @@ static void print_execve(const struct syscallname *name,
abi_long arg1,
gemu_log("NULL})");
}
-static void print_ioctl(const struct syscallname *name,
- abi_long arg1, abi_long arg2, abi_long arg3, abi_long arg4,
- abi_long arg5, abi_long arg6)
+void print_ioctl(const struct syscallname *name, abi_long arg1, abi_long arg2,
+ abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6)
{
/* Decode the ioctl request */
gemu_log("%s(%d, 0x%0lx { IO%s%s GRP:0x%x('%c') CMD:%d LEN:%d }, 0x"
@@ -124,9 +122,8 @@ static void print_ioctl(const struct syscallname *name,
arg3);
}
-static void print_sysarch(const struct syscallname *name, abi_long arg1,
- abi_long arg2, abi_long arg3, abi_long arg4, abi_long arg5,
- abi_long arg6)
+void print_sysarch(const struct syscallname *name, abi_long arg1, abi_long
arg2,
+ abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6)
{
/* This is os dependent. */
do_os_print_sysarch(name, arg1, arg2, arg3, arg4, arg5, arg6);
@@ -136,7 +133,7 @@ static void print_sysarch(const struct syscallname *name,
abi_long arg1,
* Variants for the return value output function
*/
-static void print_syscall_ret_addr(const struct syscallname *name, abi_long
ret)
+void print_syscall_ret_addr(const struct syscallname *name, abi_long ret)
{
if (ret == -1) {
gemu_log(" = -1 errno=%d (%s)\n", errno, strerror(errno));
@@ -159,9 +156,9 @@ static const struct syscallname openbsd_scnames[] = {
#include "openbsd/strace.list"
};
-static void print_syscall(int num, const struct syscallname *scnames,
- unsigned int nscnames, abi_long arg1, abi_long arg2, abi_long arg3,
- abi_long arg4, abi_long arg5, abi_long arg6)
+void print_syscall(int num, const struct syscallname *scnames,
+ unsigned int nscnames, abi_long arg1, abi_long arg2,
+ abi_long arg3, abi_long arg4, abi_long arg5, abi_long arg6)
{
unsigned int i;
const char *format="%s(" TARGET_ABI_FMT_ld "," TARGET_ABI_FMT_ld ","
@@ -190,8 +187,8 @@ static void print_syscall(int num, const struct syscallname
*scnames,
gemu_log("Unknown syscall %d\n", num);
}
-static void print_syscall_ret(int num, abi_long ret,
- const struct syscallname *scnames, unsigned int nscnames)
+void print_syscall_ret(int num, abi_long ret, const struct syscallname
*scnames,
+ unsigned int nscnames)
{
unsigned int i;
--
2.40.0
- [PATCH v2 00/19] bsd-user 2023 Q2 first batch, Warner Losh, 2023/04/10
- [PATCH v2 05/19] bsd-user: Remove NetBSD specific syscall printing, Warner Losh, 2023/04/10
- [PATCH v2 01/19] bsd-user: Make print_* public,
Warner Losh <=
- [PATCH v2 03/19] bsd-user: Cleanup style., Warner Losh, 2023/04/10
- [PATCH v2 04/19] bsd-user: Move system FreeBSD call table to freebsd/os-syscall.c, Warner Losh, 2023/04/10
- [PATCH v2 06/19] bsd-user: Remove OpenBSD specific syscall printing, Warner Losh, 2023/04/10
- [PATCH v2 07/19] bsd-user: Move system call include to os-syscall.h, Warner Losh, 2023/04/10
- [PATCH v2 08/19] bsd-user: Remove useless mmap definitions, Warner Losh, 2023/04/10
- [PATCH v2 10/19] bsd-user: Implement do_sysctl_kern_getprocs, Warner Losh, 2023/04/10
- [PATCH v2 11/19] bsd-user: Implement do_sysctl_kern_proc_filedesc, Warner Losh, 2023/04/10
- [PATCH v2 09/19] bsd-user: h2g_rusage, Warner Losh, 2023/04/10
- [PATCH v2 12/19] bsd-user: Implement do_sysctl_kern_proc_vmmap, Warner Losh, 2023/04/10
- [PATCH v2 13/19] bsd-user: Implement sysctl kern.proc, except kern.proc.full_path, Warner Losh, 2023/04/10