Re: [PATCH for-8.0 v2] target/ppc: Fix temp usage in gen_op_arith_modw

[Cédric Le Goater]

On 4/9/23 18:21, Richard Henderson wrote:
> On 4/8/23 14:24, Cédric Le Goater wrote:
> > On 4/8/23 09:05, Richard Henderson wrote:
> > > Fix a crash writing to 't3', which is now a constant.
> > > Instead, write the result of the remu to 't1'.
> > >
> > > Fixes: 7058ff5231a ("target/ppc: Avoid tcg_const_* in translate.c")
> > > Reported-by: Nicholas Piggin <npiggin@gmail.com>
> > > Reviewed-by: Anton Johansson <anjo@rev.ng>
> > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> >
> > Looks good:
> >
> >    https://gitlab.com/legoater/qemu/-/pipelines/831847446
> >
> > I have a PR ready for this same branch. If you want to me send,
> > just tell.
>
> Yes, please.  Also, the comment above needs s/t1/t0/.  :-P

sure :)

Are you taking care of :

  
20230408154316.3812709-1-richard.henderson@linaro.org">https://lore.kernel.org/r/20230408154316.3812709-1-richard.henderson@linaro.org

C.


> r~
>
> > I don't think we have tcg tests for the prefix or mma instructions
> > introduced in P10. That would be good to have.
> >
> > C.