Re: [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument

[Richard Henderson]

On 4/7/23 21:23, Richard Henderson wrote:
> On 4/5/23 09:04, Philippe Mathieu-Daudé wrote:
> > "hw/core/cpu.h" defines 'first_cpu' as QTAILQ_FIRST_RCU(&cpus).
> >
> > arm_gic_common_reset_irq_state() calls its second argument
> > 'first_cpu', producing a build failure when "hw/core/cpu.h"
> > is included:
> >
> >    hw/intc/arm_gic_common.c:238:68: warning: omitting the parameter name in a function 
> > definition is a C2x extension [-Wc2x-extensions]
> >      static inline void arm_gic_common_reset_irq_state(GICState *s, int 
> > first_cpu,
> >                                                                         ^
> >    include/hw/core/cpu.h:451:26: note: expanded from macro 'first_cpu'
> >      #define first_cpu        QTAILQ_FIRST_RCU(&cpus)
> >                               ^
> >
> > KISS, rename the function argument.
> >
> > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> > ---
> >   hw/intc/arm_gic_common.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
>
> Wow, that's ugly.  But a reasonable work-around.

Duh.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~