[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] util/error: Fix use-after-free errors reported by Coverity
From: |
Peter Maydell |
Subject: |
Re: [PATCH] util/error: Fix use-after-free errors reported by Coverity |
Date: |
Thu, 6 Apr 2023 16:50:00 +0100 |
On Thu, 6 Apr 2023 at 16:43, Stefan Berger <stefanb@linux.ibm.com> wrote:
>
> Fix use-after-free errors in the code path that called error_handle(). A
> call to error_handle() will now either free the passed Error 'err' or
> assign it to '*errp' if '*errp' is currently NULL. This ensures that 'err'
> either has been freed or is assigned to '*errp' if this function returns.
> Adjust the two callers of this function to not assign the 'err' to '*errp'
> themselves, since this is now handled by error_handle().
>
> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Do we think this needs to be fixed for 8.0 ?
thanks
-- PMM