[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/10] target/riscv: Remove check on RVH for riscv_cpu_vir
From: |
Alistair Francis |
Subject: |
Re: [PATCH v2 03/10] target/riscv: Remove check on RVH for riscv_cpu_virt_enabled |
Date: |
Wed, 5 Apr 2023 15:18:23 +1000 |
On Mon, Mar 27, 2023 at 6:12 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote:
>
> Since env->virt.VIRT_ONOFF is initialized as false, and will not be set
> to true when RVH is disabled, so we can just return this bit(false) when
> RVH is not disabled.
>
> Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu_helper.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
> index e140d6a8d0..62fd2c90f1 100644
> --- a/target/riscv/cpu_helper.c
> +++ b/target/riscv/cpu_helper.c
> @@ -560,10 +560,6 @@ void riscv_cpu_set_geilen(CPURISCVState *env,
> target_ulong geilen)
>
> bool riscv_cpu_virt_enabled(CPURISCVState *env)
> {
> - if (!riscv_has_ext(env, RVH)) {
> - return false;
> - }
> -
> return get_field(env->virt, VIRT_ONOFF);
> }
>
> --
> 2.25.1
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 03/10] target/riscv: Remove check on RVH for riscv_cpu_virt_enabled,
Alistair Francis <=