[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/10] target/riscv: Remove redundant call to riscv_cpu_vi
From: |
Alistair Francis |
Subject: |
Re: [PATCH v2 01/10] target/riscv: Remove redundant call to riscv_cpu_virt_enabled |
Date: |
Wed, 5 Apr 2023 15:17:21 +1000 |
On Mon, Mar 27, 2023 at 6:11 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote:
>
> The assignment is done under the condition riscv_cpu_virt_enabled()=true.
>
> Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu_helper.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
> index 824f0cbd92..e140d6a8d0 100644
> --- a/target/riscv/cpu_helper.c
> +++ b/target/riscv/cpu_helper.c
> @@ -1706,9 +1706,7 @@ void riscv_cpu_do_interrupt(CPUState *cs)
> riscv_cpu_swap_hypervisor_regs(env);
> env->hstatus = set_field(env->hstatus, HSTATUS_SPVP,
> env->priv);
> - env->hstatus = set_field(env->hstatus, HSTATUS_SPV,
> - riscv_cpu_virt_enabled(env));
> -
> + env->hstatus = set_field(env->hstatus, HSTATUS_SPV, true);
>
> htval = env->guest_phys_fault_addr;
>
> --
> 2.25.1
>
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 01/10] target/riscv: Remove redundant call to riscv_cpu_virt_enabled,
Alistair Francis <=