Re: [PATCH for-8.0] tcg/sparc64: Disable direct linking for goto_tb

[Richard Henderson]

On 4/4/23 08:32, Alex Bennée wrote:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
> > Something is wrong with this code, and also wrong with gdb on the
> > sparc systems to which I have access, so I cannot debug it either.
> > Disable for now, so the release is not broken.
>
> Why isn't this a revert then?

A revert of a228ae3ea7f6 wouldn't build.
This was part of an infrastructure change.

> So the result it we never patch the jump so return to the main loop
> after every block?

No, we simply perform an indirect branch to the next block.
Slower than a direct branch, but way faster than returning
to the main loop.

> In so far this won't break anything else and I suspect you are one of
> the last people who actually uses the backend:

Probably.

> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Thanks,


r~