[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/10] gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if n
From: |
Alex Bennée |
Subject: |
[PULL 02/10] gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if necessary |
Date: |
Tue, 4 Apr 2023 15:59:17 +0100 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
It is pointless to build libgdb_user.fa in a system-only build
(or libgdb_softmmu.fa in a user-only build). Besides, in some
restricted build configurations, some APIs might be restricted /
not available. Example in a KVM-only builds where TCG is disabled:
$ ninja qemu-system-x86_64
[99/2187] Compiling C object gdbstub/libgdb_user.fa.p/user.c.o
FAILED: gdbstub/libgdb_user.fa.p/user.c.o
../../gdbstub/user.c: In function ‘gdb_breakpoint_insert’:
../../gdbstub/user.c:438:19: error: implicit declaration of function
‘cpu_breakpoint_insert’; did you mean ‘gdb_breakpoint_insert’?
[-Werror=implicit-function-declaration]
438 | err = cpu_breakpoint_insert(cpu, addr, BP_GDB, NULL);
| ^~~~~~~~~~~~~~~~~~~~~
| gdb_breakpoint_insert
../../gdbstub/user.c:438:19: error: nested extern declaration of
‘cpu_breakpoint_insert’ [-Werror=nested-externs]
../../gdbstub/user.c: In function ‘gdb_breakpoint_remove’:
../../gdbstub/user.c:459:19: error: implicit declaration of function
‘cpu_breakpoint_remove’; did you mean ‘gdb_breakpoint_remove’?
[-Werror=implicit-function-declaration]
459 | err = cpu_breakpoint_remove(cpu, addr, BP_GDB);
| ^~~~~~~~~~~~~~~~~~~~~
| gdb_breakpoint_remove
../../gdbstub/user.c:459:19: error: nested extern declaration of
‘cpu_breakpoint_remove’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.
Fixes: 61b2e136db ("gdbstub: only compile gdbstub twice for whole build")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230329161852.84992-1-philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230403134920.2132362-3-alex.bennee@linaro.org>
diff --git a/gdbstub/meson.build b/gdbstub/meson.build
index bd5c5cd67d..cdb4d28691 100644
--- a/gdbstub/meson.build
+++ b/gdbstub/meson.build
@@ -20,11 +20,13 @@ gdb_softmmu_ss = gdb_softmmu_ss.apply(config_host, strict:
false)
libgdb_user = static_library('gdb_user',
gdb_user_ss.sources() + genh,
name_suffix: 'fa',
- c_args: '-DCONFIG_USER_ONLY')
+ c_args: '-DCONFIG_USER_ONLY',
+ build_by_default: have_user)
libgdb_softmmu = static_library('gdb_softmmu',
gdb_softmmu_ss.sources() + genh,
- name_suffix: 'fa')
+ name_suffix: 'fa',
+ build_by_default: have_system)
gdb_user = declare_dependency(link_whole: libgdb_user)
user_ss.add(gdb_user)
--
2.39.2
- [PULL for 8.0 00/10] misc fixes (tests, gdbstub, metadata), Alex Bennée, 2023/04/04
- [PULL 01/10] scripts/coverage: initial coverage comparison script, Alex Bennée, 2023/04/04
- [PULL 03/10] gdbstub: don't report auxv feature unless on Linux, Alex Bennée, 2023/04/04
- [PULL 04/10] MAINTAINERS: add a section for policy documents, Alex Bennée, 2023/04/04
- [PULL 10/10] tests/avocado: Test Xen guest support under KVM, Alex Bennée, 2023/04/04
- [PULL 08/10] tests/vm: use the default system python for NetBSD, Alex Bennée, 2023/04/04
- [PULL 05/10] metadata: add .git-blame-ignore-revs, Alex Bennée, 2023/04/04
- [PULL 02/10] gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if necessary,
Alex Bennée <=
- [PULL 07/10] tests/qemu-iotests: explicitly invoke 'check' via 'python', Alex Bennée, 2023/04/04
- [PULL 06/10] Use hexagon toolchain version 16.0.0, Alex Bennée, 2023/04/04
- [PULL 09/10] gitlab: fix typo, Alex Bennée, 2023/04/04
- Re: [PULL for 8.0 00/10] misc fixes (tests, gdbstub, metadata), Peter Maydell, 2023/04/04