Re: [PATCH 2/3] accel/tcg: Fix overwrite problems of tcg_cflags

[Philippe Mathieu-Daudé]

On 3/4/23 12:44, Anton Johansson wrote:
> On 4/3/23 11:09, liweiwei wrote:
> > On 2023/4/3 16:09, Philippe Mathieu-Daudé wrote:
> > >      cflags |= parallel ? CF_PARALLEL : 0;
> > >      cflags |= icount_enabled() ? CF_USE_ICOUNT : 0;
> > > +    tcg_debug_assert(!cpu->tcg_cflags);
> > >      cpu->tcg_cflags = cflags;
> > >  }
> > > ---
> > >
> > > Li and Junqiang, what is your use case?
> >
> > Only few CPUs support CF_PCREL currently. I found this problem when I 
> > tried to introduce PC-relative translation into RISC-V.
> >
> > Maybe It also can be reproduced in system mode for ARM and X86.
>
> Yes, this can be reproduced on arm-softmmu with --enable-debug-tcg and 
> the above assertion.

Ah OK. Then...

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>