[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND 2/2] migration/ram.c: Fix migration with compress enab
From: |
Peter Xu |
Subject: |
Re: [PATCH RESEND 2/2] migration/ram.c: Fix migration with compress enabled |
Date: |
Mon, 3 Apr 2023 17:19:40 -0400 |
On Sun, Apr 02, 2023 at 05:48:38PM +0000, Lukas Straub wrote:
> Since ec6f3ab9, migration with compress enabled was broken, because
> the compress threads use a dummy QEMUFile which just acts as a
> buffer and that commit accidentally changed it to use the outgoing
> migration channel instead.
Sorry. :(
> Fix this by using the dummy file again in the compress threads.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Let's also add a Fixes tag to be clear:
ec6f3ab9f4 ("migration: Move last_sent_block into PageSearchStatus")
Even though it may not need to copy stable.
I think this is for 8.0, am I right? It should be very clear if so,
otherwise it's easy to get overlooked.
--
Peter Xu