Re: [PATCH v2 00/10] Deprecate/rename singlestep command line option, monitor interfaces

[Richard Henderson]

On 4/3/23 07:46, Peter Maydell wrote:
>   * I have written patch 3 on the assumption that curr_cflags()
>     is not such a hot codepath that we can't afford to have
>     a QOM cast macro in it; the alternative would be to
>     keep it using a global variable but make the global be
>     restricted to accel/tcg/internals.h. RTH: opinions welcome...

curr_cflags() is quite hot, called from lookup_tb_ptr every time we time we end a chain of 
directly linked TBs.  You'll see lookup_tb_ptr near the top of any tcg profile.

With a global variable, it might be worth combining with CPU_LOG_TB_NOCHAIN, recomputing 
the global if either option changes.


r~