qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] target/loongarch: Enables plugins to get instruction code


From: Alex Bennée
Subject: Re: [PATCH v2] target/loongarch: Enables plugins to get instruction codes
Date: Mon, 03 Apr 2023 14:11:56 +0100
User-agent: mu4e 1.10.0; emacs 29.0.60

tanhongze <tanhongze@loongson.cn> writes:

> Signed-off-by: tanhongze <tanhongze@loongson.cn>

It looks like you've missed the review tags from the last posting.

Acked-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  target/loongarch/translate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/loongarch/translate.c b/target/loongarch/translate.c
> index 3bb63bfb3e..50d6b62f39 100644
> --- a/target/loongarch/translate.c
> +++ b/target/loongarch/translate.c
> @@ -198,7 +198,7 @@ static void loongarch_tr_translate_insn(DisasContextBase 
> *dcbase, CPUState *cs)
>      CPULoongArchState *env = cs->env_ptr;
>      DisasContext *ctx = container_of(dcbase, DisasContext, base);
>  
> -    ctx->opcode = cpu_ldl_code(env, ctx->base.pc_next);
> +    ctx->opcode = translator_ldl(env, &ctx->base, ctx->base.pc_next);
>  
>      if (!decode(ctx, ctx->opcode)) {
>          qemu_log_mask(LOG_UNIMP, "Error: unknown opcode. "


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



reply via email to

[Prev in Thread] Current Thread [Next in Thread]