[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 6/7] hw/isa/piix3: Resolve redundant k->config_write assignmen
From: |
Bernhard Beschow |
Subject: |
[PATCH v4 6/7] hw/isa/piix3: Resolve redundant k->config_write assignments |
Date: |
Mon, 3 Apr 2023 09:41:23 +0200 |
The previous patch unified handling of piix3_write_config() accross the
PIIX3 device models which allows for assigning k->config_write once in the
base class.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Tested-by: Chuck Zmudzinski <brchuckz@aol.com>
Message-Id: <20230312120221.99183-6-shentey@gmail.com>
---
hw/isa/piix3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c
index 737f5c6a5d..418940139d 100644
--- a/hw/isa/piix3.c
+++ b/hw/isa/piix3.c
@@ -308,6 +308,7 @@ static void pci_piix3_class_init(ObjectClass *klass, void
*data)
PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
AcpiDevAmlIfClass *adevc = ACPI_DEV_AML_IF_CLASS(klass);
+ k->config_write = piix3_write_config;
dc->reset = piix3_reset;
dc->desc = "ISA bridge";
dc->vmsd = &vmstate_piix3;
@@ -356,7 +357,6 @@ static void piix3_class_init(ObjectClass *klass, void *data)
{
PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
- k->config_write = piix3_write_config;
k->realize = piix3_realize;
}
@@ -370,7 +370,6 @@ static void piix3_xen_class_init(ObjectClass *klass, void
*data)
{
PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
- k->config_write = piix3_write_config;
k->realize = piix3_realize;
}
--
2.40.0
- [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE, Bernhard Beschow, 2023/04/03
- [PATCH v4 1/7] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq(), Bernhard Beschow, 2023/04/03
- [PATCH v4 2/7] hw/pci/pci.c: Don't leak PCIBus::irq_count[] in pci_bus_irqs(), Bernhard Beschow, 2023/04/03
- [PATCH v4 7/7] hw/isa/piix3: Resolve redundant TYPE_PIIX3_XEN_DEVICE, Bernhard Beschow, 2023/04/03
- [PATCH v4 3/7] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize(), Bernhard Beschow, 2023/04/03
- [PATCH v4 4/7] hw/isa/piix3: Wire up Xen PCI IRQ handling outside of PIIX3, Bernhard Beschow, 2023/04/03
- [PATCH v4 5/7] hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config(), Bernhard Beschow, 2023/04/03
- [PATCH v4 6/7] hw/isa/piix3: Resolve redundant k->config_write assignments,
Bernhard Beschow <=
- Re: [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE, Michael S. Tsirkin, 2023/04/21