qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 32/44] target/loongarch: Implement vbitclr vbitset vbi


From: Richard Henderson
Subject: Re: [RFC PATCH v2 32/44] target/loongarch: Implement vbitclr vbitset vbitrev
Date: Sat, 1 Apr 2023 22:14:03 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0

On 3/27/23 20:06, Song Gao wrote:
+#define DO_BITCLR(a, bit) (a & ~(1ul << bit))
+#define DO_BITSET(a, bit) (a | 1ul << bit)
+#define DO_BITREV(a, bit) (a ^ (1ul << bit))

ul.

Also, the *i versions should always be inline.
And it should be trivial to expand the non-i versions inline, with shl.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]