[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] hostmem-file: add offset option
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v4] hostmem-file: add offset option |
Date: |
Sat, 1 Apr 2023 13:47:16 -0400 |
On Sat, Apr 01, 2023 at 12:42:57PM +0000, Alexander Graf wrote:
> Add an option for hostmem-file to start the memory object at an offset
> into the target file. This is useful if multiple memory objects reside
> inside the same target file, such as a device node.
>
> In particular, it's useful to map guest memory directly into /dev/mem
> for experimentation.
>
> Signed-off-by: Alexander Graf <graf@amazon.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
>
> ---
>
> v1 -> v2:
>
> - add qom documentation
> - propagate offset into truncate, size and alignment checks
>
> v2 -> v3:
>
> - failed attempt at fixing typo
>
> v2 -> v4:
>
> - fix typo
> ---
> backends/hostmem-file.c | 40 +++++++++++++++++++++++++++++++++++++++-
> include/exec/memory.h | 2 ++
> include/exec/ram_addr.h | 3 ++-
> qapi/qom.json | 5 +++++
> qemu-options.hx | 6 +++++-
> softmmu/memory.c | 3 ++-
> softmmu/physmem.c | 14 ++++++++++----
> 7 files changed, 65 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature