Re: [RFC PATCH v2 26/44] target/loongarch: Implement vsrln vsran

[Richard Henderson]

On 3/27/23 20:06, Song Gao wrote:
> This patch includes:
> - VSRLN.{B.H/H.W/W.D};
> - VSRAN.{B.H/H.W/W.D};
> - VSRLNI.{B.H/H.W/W.D/D.Q};
> - VSRANI.{B.H/H.W/W.D/D.Q}.
>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   target/loongarch/disas.c                    |  16 +++
>   target/loongarch/helper.h                   |  16 +++
>   target/loongarch/insn_trans/trans_lsx.c.inc |  16 +++
>   target/loongarch/insns.decode               |  17 +++
>   target/loongarch/lsx_helper.c               | 118 ++++++++++++++++++++
>   5 files changed, 183 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> +    Vd->D(0) = temp.D(0);                                    \
> +    Vd->D(1) = temp.D(1);          

Oh, just noticed but lots of instances: better as *Vd = temp.


r~