[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-8.0] block/export: fix assume_graph_lock() assertion fail
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH for-8.0] block/export: fix assume_graph_lock() assertion failure |
|
Date: |
Tue, 28 Mar 2023 11:09:08 -0400 |
On Tue, Mar 28, 2023 at 02:27:35PM +0200, Kevin Wolf wrote:
> Am 27.03.2023 um 23:19 hat Stefan Hajnoczi geschrieben:
> > When I/O request parameters are validated for virtio-blk exports like
> > vhost-user-blk and vduse-blk, we call blk_get_geometry() from a
> > coroutine. This hits an assume_graph_lock() assertion failure.
> >
> > Use blk_co_nb_sectors() instead and mark virtio_blk_sect_range_ok() with
> > coroutine_fn.
> >
> > This assertion failure is triggered by any I/O to a vhost-user-blk
> > export.
> >
> > Fixes: 8ab8140a04cf ("block: Mark bdrv_co_refresh_total_sectors() and
> > callers GRAPH_RDLOCK")
> > Cc: Kevin Wolf <kwolf@redhat.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> This is a duplicate of this fix:
>
> 20230327113959.60071-1-kwolf@redhat.com/">https://patchew.org/QEMU/20230327113959.60071-1-kwolf@redhat.com/
Okay, thanks. Your fix looks good.
Stefan
signature.asc
Description: PGP signature