[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: QMP command dumpdtb crash bug
From: |
Peter Maydell |
Subject: |
Re: QMP command dumpdtb crash bug |
Date: |
Thu, 23 Mar 2023 13:38:50 +0000 |
On Thu, 23 Mar 2023 at 13:29, Markus Armbruster <armbru@redhat.com> wrote:
>
> Peter, Daniel offers two ways to fix this bug (see below). Got a
> preference?
Not freeing seems the correct thing. As Daniel says, this
should have been a prerequisite for implementing the
command in the first place (you need to change the lifecycle
of the fdt blob from "delete when done with in the arm boot code"
to "delete on machine finalize"). It looks like somehow we added
the command but missed out on getting all of the prerequisite
patches in. (File under "need to be cautious about applying partial
patchsets", I guess.)
Did anything else from that initial patchset get omitted?
thanks
-- PMM