Re: [PATCH 02/45] target/riscv: Refactor some of the generic vector func

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/45] target/riscv: Refactor some of the generic vector func

From:	Lawrence Hunter
Subject:	Re: [PATCH 02/45] target/riscv: Refactor some of the generic vector functionality
Date:	Thu, 23 Mar 2023 11:34:09 +0000

On 21/03/2023 12:02, Christoph Müllner wrote:

On Fri, Mar 10, 2023 at 5:06 PM Lawrence Hunter
<lawrence.hunter@codethink.co.uk> wrote:


From: Kiran Ostrolenk <kiran.ostrolenk@codethink.co.uk>

Summary of refactoring:

* take some functions/macros out of `vector_helper` and put them in a
new module called `vector_internals`

* factor the non SEW-specific stuff out of `GEN_OPIVV_TRANS` into
function `opivv_trans` (similar to `opivi_trans`)


I think splitting this commit into two changes would be better.
Besides that the two changes look reasonable and correct.


Makes sense, we can do this

Best,
Lawrence

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 00/45] Add RISC-V vector cryptographic instruction set support, (continued)
- [PATCH 00/45] Add RISC-V vector cryptographic instruction set support, Lawrence Hunter, 2023/03/10
  - [PATCH 05/45] target/riscv: Add vclmul.vx decoding, translation and execution support, Lawrence Hunter, 2023/03/10
  - [PATCH 07/45] target/riscv: Add vclmulh.vx decoding, translation and execution support, Lawrence Hunter, 2023/03/10
  - [PATCH 09/45] qemu/bitops.h: Limit rotate amounts, Lawrence Hunter, 2023/03/10
  - [PATCH 03/45] target/riscv: Add vclmul.vv decoding, translation and execution support, Lawrence Hunter, 2023/03/10
  - [PATCH 01/45] target/riscv: Add zvkb cpu property, Lawrence Hunter, 2023/03/10
  - [PATCH 02/45] target/riscv: Refactor some of the generic vector functionality, Lawrence Hunter, 2023/03/10
    - Re: [PATCH 02/45] target/riscv: Refactor some of the generic vector functionality, Christoph Müllner, 2023/03/21
    - Re: [PATCH 02/45] target/riscv: Refactor some of the generic vector functionality, Lawrence Hunter <=
  - [PATCH 06/45] target/riscv: Add vclmulh.vv decoding, translation and execution support, Lawrence Hunter, 2023/03/10
  - [PATCH 11/45] target/riscv: Refactor some of the generic vector functionality, Lawrence Hunter, 2023/03/10
  - [PATCH 08/45] target/riscv: Refactor some of the generic vector functionality, Lawrence Hunter, 2023/03/10
  - [PATCH 16/45] target/riscv: Add zvkned cpu property, Lawrence Hunter, 2023/03/10
  - [PATCH 19/45] target/riscv: Add vaesdf.vv decoding, translation and execution support, Lawrence Hunter, 2023/03/10
  - [PATCH 22/45] target/riscv: Add vaesdm.vs decoding, translation and execution support, Lawrence Hunter, 2023/03/10
  - [PATCH 18/45] target/riscv: Add vaesef.vs decoding, translation and execution support, Lawrence Hunter, 2023/03/10
  - [PATCH 12/45] target/riscv: Add vbrev8.v decoding, translation and execution support, Lawrence Hunter, 2023/03/10
  - [PATCH 15/45] target/riscv: Expose zvkb cpu property, Lawrence Hunter, 2023/03/10
  - [PATCH 14/45] target/riscv: Add vandn.[vv, vx] decoding, translation and execution support, Lawrence Hunter, 2023/03/10

Prev by Date: Re: [PATCH] hw/arm/virt: support both pl011 and 16550 uart
Next by Date: Re: [PATCH 00/45] Add RISC-V vector cryptographic instruction set support
Previous by thread: Re: [PATCH 02/45] target/riscv: Refactor some of the generic vector functionality
Next by thread: [PATCH 06/45] target/riscv: Add vclmulh.vv decoding, translation and execution support
Index(es):
- Date
- Thread