Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

[Alessandro Di Federico]

On Mon, 20 Mar 2023 10:10:27 +0000
Alex Bennée <alex.bennee@linaro.org> wrote:

> This doesn't save much as cpu-exec-common still needs to be built
> per-target for its knowledge of CPUState but this helps with keeping
> things organised.

> --- /dev/null
> +++ b/accel/tcg/cpu-exec-softmmu.c

Could `cpu_reloading_memory_map` be pushed closer to its only user
(softmmu/physmem.c) instead of creating a new file in accel/tcg?

Maybe I'm missing something, but I see other usages of current_cpu in
softmmu:

    $ git grep 'current_cpu->' softmmu/|cat
    softmmu/cpus.c:        current_cpu->stop = true;
    softmmu/memory.c:        return current_cpu->cpu_index;
    softmmu/runstate.c:        current_cpu->crash_occurred = true;

Maybe you envision more stuff in cpu-exec-softmmu.c.

Reviewed-by: Alessandro Di Federico <ale@rev.ng>

-- 
Alessandro Di Federico
rev.ng Labs