[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/14] qapi: Simplify code a bit after previous commit
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 06/14] qapi: Simplify code a bit after previous commit |
Date: |
Fri, 17 Mar 2023 06:42:46 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On Thu, Mar 16, 2023 at 08:13:17AM +0100, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Looks like 'previous commit' in the subject line actually means 4/14
> (two commits ago); a victim of rebasing, I'm sure.
Hmm, actually both commits matter.
The first hunk simplifies check_type_name() by contracting its two
conditionals. It is enabled by the previous commit, which removed the
code between the two conditionals.
The second hunk simplifies check_type_name_or_array() the same way, but
that one has had nothing in between since PATCH 04.
I'll change the title to "after previous commits".
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks!
- Re: [PATCH 12/14] tests/qapi-schema: Cover optional conditional struct member, (continued)
- [PATCH 14/14] qapi: Require boxed for conditional command and event arguments, Markus Armbruster, 2023/03/16
- [PATCH 04/14] qapi: Split up check_type(), Markus Armbruster, 2023/03/16
- [PATCH 03/14] qapi: Clean up after removal of simple unions, Markus Armbruster, 2023/03/16
- [PATCH 06/14] qapi: Simplify code a bit after previous commit, Markus Armbruster, 2023/03/16
- [PATCH 09/14] tests/qapi-schema: Improve union discriminator coverage, Markus Armbruster, 2023/03/16
- [PATCH 07/14] qapi: Fix error message when type name or array is expected, Markus Armbruster, 2023/03/16
- [PATCH 10/14] tests/qapi-schema: Rename a few conditionals, Markus Armbruster, 2023/03/16