[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/14] qapi: Require boxed for conditional command and event
From: |
Eric Blake |
Subject: |
Re: [PATCH 14/14] qapi: Require boxed for conditional command and event arguments |
Date: |
Thu, 16 Mar 2023 20:17:04 -0500 |
User-agent: |
NeoMutt/20220429 |
On Thu, Mar 16, 2023 at 08:13:25AM +0100, Markus Armbruster wrote:
> The C code generator fails to honor 'if' conditions of command and
> event arguments.
>
...
>
> Conditional arguments work fine with 'boxed': true, simply because
> complex types with conditional members work fine. Not worth breaking.
>
> Reject conditional arguments unless boxed.
Yay - matches my earlier suggestion at how to avoid #if in the middle
of a parameter list.
>
> Move the tests cases covering unboxed conditional arguments out of
> tests/qapi-schema/qapi-schema-test.json. Cover boxed conditional
> arguments there instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
A big end to the series, but I'm glad we got here.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH 02/14] qapi/schema: Use super(), (continued)
- [PATCH 02/14] qapi/schema: Use super(), Markus Armbruster, 2023/03/16
- [PATCH 01/14] qapi: Fix error message format regression, Markus Armbruster, 2023/03/16
- [PATCH 08/14] qapi: Fix to reject 'data': 'mumble' in struct, Markus Armbruster, 2023/03/16
- [PATCH 12/14] tests/qapi-schema: Cover optional conditional struct member, Markus Armbruster, 2023/03/16
- [PATCH 14/14] qapi: Require boxed for conditional command and event arguments, Markus Armbruster, 2023/03/16
- Re: [PATCH 14/14] qapi: Require boxed for conditional command and event arguments,
Eric Blake <=
- [PATCH 04/14] qapi: Split up check_type(), Markus Armbruster, 2023/03/16
- [PATCH 03/14] qapi: Clean up after removal of simple unions, Markus Armbruster, 2023/03/16
- [PATCH 06/14] qapi: Simplify code a bit after previous commit, Markus Armbruster, 2023/03/16
- [PATCH 09/14] tests/qapi-schema: Improve union discriminator coverage, Markus Armbruster, 2023/03/16