qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/14] qapi: Fix error message format regression


From: Eric Blake
Subject: Re: [PATCH 01/14] qapi: Fix error message format regression
Date: Thu, 16 Mar 2023 16:56:34 -0500
User-agent: NeoMutt/20220429

On Thu, Mar 16, 2023 at 08:13:12AM +0100, Markus Armbruster wrote:
> Commit 52a474180ae3 changed reporting of errors connected to a source
> location without mentioning it in the commit message.  For instance,
> 
>     $ python scripts/qapi-gen.py tests/qapi-schema/unknown-escape.json
>     tests/qapi-schema/unknown-escape.json:3:21: unknown escape \x
> 
> became
> 
>     scripts/qapi-gen.py: tests/qapi-schema/unknown-escape.json:3:21: unknown 
> escape \x
> 
> This is not how compilers report such errors, and Emacs doesn't
> recognize the format.  Revert this change.
> 
> Fixes: 52a474180ae3 (qapi-gen: Separate arg-parsing from generation)
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  scripts/qapi/main.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]