Re: [PATCH v2 1/3] qapi/machine-target: refactor machine-target

[Philippe Mathieu-Daudé]

On 14/3/23 11:00, Dinah Baum wrote:
> Moved architecture agnostic data types to their own
> file to avoid "attempt to use poisoned TARGET_*"
> error that results when including qapi header
> with commands that aren't defined for all architectures.
> Required to implement enabling `query-cpu-model-expansion`
> on all architectures
>
> Signed-off-by: Dinah Baum <dinahbaum123@gmail.com>
> ---
>   MAINTAINERS                     |  1 +
>   qapi/machine-target-common.json | 79 +++++++++++++++++++++++++++++++++
>   qapi/machine-target.json        | 73 +-----------------------------
>   qapi/meson.build                |  1 +
>   4 files changed, 82 insertions(+), 72 deletions(-)
>   create mode 100644 qapi/machine-target-common.json

> diff --git a/qapi/meson.build b/qapi/meson.build
> index 9fd480c4d8..48be47170f 100644
> --- a/qapi/meson.build
> +++ b/qapi/meson.build
> @@ -38,6 +38,7 @@ qapi_all_modules = [
>     'job',
>     'machine',
>     'machine-target',
> +  'machine-target-common',
>     'migration',
>     'misc',
>     'misc-target',

Eh, this reminds me of
https://lore.kernel.org/qemu-devel/20220204152924.6253-5-f4bug@amsat.org/

I wonder between -common / -any / -all. Anyhow,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>