Re: [PATCH v8 03/11] target/arm: Move aa32_max_features out of cpu_tcg.c

[Richard Henderson]

On 3/9/23 12:14, Fabiano Rosas wrote:
> In preparation to moving the cpu_tcg.c code into a 32-bit, tcg-only
> file, move the aa32_max_features function which is shared between
> 32/64/tcg/non-tcg into cpu.c.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   target/arm/cpu.c     | 69 ++++++++++++++++++++++++++++++++++++++++++++
>   target/arm/cpu_tcg.c | 69 --------------------------------------------
>   2 files changed, 69 insertions(+), 69 deletions(-)

I'm not keen on this, as it's completely tcg.

Perhaps it would be better to let -cpu max devolve to aarch64_a57_initfn when tcg is not 
available (i.e. qtest_enabled())?  Move all of the tcg stuff out of aarch64_max_initfn 
into tcg/cpu64.c.

Thoughts?


r~