[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 87/91] target/ppc: Fix gen_tlbsx_booke206
From: |
Richard Henderson |
Subject: |
[PULL v2 87/91] target/ppc: Fix gen_tlbsx_booke206 |
Date: |
Thu, 9 Mar 2023 12:05:46 -0800 |
Fix incorrect read from rD.
Avoid adding 0 when rA == 0.
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/ppc/translate.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index df324fc7ff..7ec940b7d8 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -5875,12 +5875,10 @@ static void gen_tlbsx_booke206(DisasContext *ctx)
CHK_SV(ctx);
if (rA(ctx->opcode)) {
t0 = tcg_temp_new();
- tcg_gen_mov_tl(t0, cpu_gpr[rD(ctx->opcode)]);
+ tcg_gen_add_tl(t0, cpu_gpr[rA(ctx->opcode)], cpu_gpr[rB(ctx->opcode)]);
} else {
- t0 = tcg_const_tl(0);
+ t0 = cpu_gpr[rB(ctx->opcode)];
}
-
- tcg_gen_add_tl(t0, t0, cpu_gpr[rB(ctx->opcode)]);
gen_helper_booke206_tlbsx(cpu_env, t0);
#endif /* defined(CONFIG_USER_ONLY) */
}
--
2.34.1
- [PULL v2 74/91] target/arm: Avoid tcg_const_ptr in gen_sve_{ldr,str}, (continued)
- [PULL v2 74/91] target/arm: Avoid tcg_const_ptr in gen_sve_{ldr,str}, Richard Henderson, 2023/03/09
- [PULL v2 78/91] target/arm: Avoid tcg_const_ptr in handle_rev, Richard Henderson, 2023/03/09
- [PULL v2 71/91] target/arm: Consistently use ARMFPRounding during translation, Richard Henderson, 2023/03/09
- [PULL v2 72/91] target/arm: Create gen_set_rmode, gen_restore_rmode, Richard Henderson, 2023/03/09
- [PULL v2 79/91] target/m68k: Use tcg_constant_i32 in gen_ea_mode, Richard Henderson, 2023/03/09
- [PULL v2 77/91] target/arm: Avoid tcg_const_ptr in handle_vec_simd_sqshrn, Richard Henderson, 2023/03/09
- [PULL v2 75/91] target/arm: Avoid tcg_const_* in translate-mve.c, Richard Henderson, 2023/03/09
- [PULL v2 76/91] target/arm: Avoid tcg_const_ptr in disas_simd_zip_trn, Richard Henderson, 2023/03/09
- [PULL v2 73/91] target/arm: Improve trans_BFCI, Richard Henderson, 2023/03/09
- [PULL v2 85/91] target/ppc: Avoid tcg_const_* in power8-pmu-regs.c.inc, Richard Henderson, 2023/03/09
- [PULL v2 87/91] target/ppc: Fix gen_tlbsx_booke206,
Richard Henderson <=
- [PULL v2 91/91] tcg: Drop tcg_const_*, Richard Henderson, 2023/03/09
- [PULL v2 90/91] tcg: Drop tcg_const_*_vec, Richard Henderson, 2023/03/09
- [PULL v2 89/91] target/tricore: Use min/max for saturate, Richard Henderson, 2023/03/09
- [PULL v2 88/91] target/ppc: Avoid tcg_const_* in translate.c, Richard Henderson, 2023/03/09
- [PULL v2 86/91] target/ppc: Rewrite trans_ADDG6S, Richard Henderson, 2023/03/09
- [PULL v2 80/91] target/ppc: Avoid tcg_const_i64 in do_vcntmb, Richard Henderson, 2023/03/09
- [PULL v2 81/91] target/ppc: Avoid tcg_const_* in vmx-impl.c.inc, Richard Henderson, 2023/03/09
- [PULL v2 83/91] target/ppc: Avoid tcg_const_* in vsx-impl.c.inc, Richard Henderson, 2023/03/09
- [PULL v2 82/91] target/ppc: Avoid tcg_const_* in xxeval, Richard Henderson, 2023/03/09
- [PULL v2 84/91] target/ppc: Avoid tcg_const_* in fp-impl.c.inc, Richard Henderson, 2023/03/09