Re: [PATCH v2 22/25] target/ppc: Avoid tcg_const_* in translate.c

[Philippe Mathieu-Daudé]

On 7/3/23 19:35, Richard Henderson wrote:
> All remaining uses are strictly read-only.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> Cc: Daniel Henrique Barboza <danielhb413@gmail.com>
> Cc: Cédric Le Goater <clg@kaod.org>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Greg Kurz <groug@kaod.org>
> Cc: qemu-ppc@nongnu.org
> ---
>   target/ppc/translate.c | 142 +++++++++++++++++++++--------------------
>   1 file changed, 72 insertions(+), 70 deletions(-)


> @@ -386,7 +386,7 @@ void spr_noaccess(DisasContext *ctx, int gprn, int sprn)
>   static void spr_load_dump_spr(int sprn)
>   {
>   #ifdef PPC_DUMP_SPR_ACCESSES
> -    TCGv_i32 t0 = tcg_const_i32(sprn);
> +    TCGv_i32 t0 = tcg_constant_i32(sprn);
>       gen_helper_load_dump_spr(cpu_env, t0);
>   #endif
>   }
> @@ -400,7 +400,7 @@ void spr_read_generic(DisasContext *ctx, int gprn, int sprn)
>   static void spr_store_dump_spr(int sprn)
>   {
>   #ifdef PPC_DUMP_SPR_ACCESSES
> -    TCGv_i32 t0 = tcg_const_i32(sprn);
> +    TCGv_i32 t0 = tcg_constant_i32(sprn);
>       gen_helper_store_dump_spr(cpu_env, t0);
>   #endif
>   }

Unrelated, but probably better to convert this PPC_DUMP_SPR_ACCESSES
#ifdef'ry to a boolean in DisasContext.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>