Re: [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU

[Dorinda Bassey]

Hi

Unfortunately, you are not calling pw_thread_loop_wait yourself, so
that doesn't help me what this is supposed to do. When signaling
things and expecting a certain state and side-effect from a different
thread or context, it's nice to document it.

I guess this will break the thread loop? What happens next?

In this case When the on_core_done event is received for an object with id `PW_ID_CORE` this function would call the thread_loop_signal(loop, FALSE) to stop and exit the thread loop. I would add a comment for this, to be clear.

Thanks,

Dorinda.

On Tue, Mar 7, 2023 at 2:49 PM Marc-André Lureau <marcandre.lureau@gmail.com> wrote:

Hi

On Fri, Mar 3, 2023 at 8:06 PM Dorinda Bassey
>> What are those thread_loop_signal() for? Maybe leave a comment?
>
> the explanation of the function is in the reference header file.
>

Yes, I read the reference documentation before asking: "Signal all
threads waiting with pw_thread_loop_wait."
(https://docs.pipewire.org/group__pw__thread__loop.html#gaf9bc8dd348d05b095139f5a55ac5a4b0)

Unfortunately, you are not calling pw_thread_loop_wait yourself, so
that doesn't help me what this is supposed to do. When signaling
things and expecting a certain state and side-effect from a different
thread or context, it's nice to document it.

I guess this will break the thread loop? What happens next?

thanks

--
Marc-André Lureau