[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 00/16] hw/9pfs: Add 9pfs support for Windows
From: |
Bin Meng |
Subject: |
Re: [PATCH v5 00/16] hw/9pfs: Add 9pfs support for Windows |
Date: |
Mon, 6 Mar 2023 22:56:49 +0800 |
On Mon, Mar 6, 2023 at 10:15 PM Christian Schoenebeck
<qemu_oss@crudebyte.com> wrote:
>
> On Monday, February 20, 2023 11:07:59 AM CET Bin Meng wrote:
> > At present there is no Windows support for 9p file system.
> > This series adds initial Windows support for 9p file system.
> >
> > 'local' file system backend driver is supported on Windows,
> > including open, read, write, close, rename, remove, etc.
> > All security models are supported. The mapped (mapped-xattr)
> > security model is implemented using NTFS Alternate Data Stream
> > (ADS) so the 9p export path shall be on an NTFS partition.
> >
> > 'synth' driver is adapted for Windows too so that we can now
> > run qtests on Windows for 9p related regression testing.
> >
> > Example command line to test:
> > "-fsdev local,path=c:\msys64,security_model=mapped,id=p9 -device
> virtio-9p-pci,fsdev=p9,mount_tag=p9fs"
> >
> > Changes in v5:
> > - rework Windows specific xxxdir() APIs implementation
>
> I didn't have the chance to look at this v5 yet.
>
> In general it would help for review to point out in the cover letter which
> patch(es) have changed, what decisions you have made and why.
>
> In this case I guess that's patch 4.
>
Yes, it's patch 4, and v5 is reworked following your comments
regarding patch 4 of v4.
Regards,
Bin