On Thu, Mar 02, 2023 at 05:18:44PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> Meson "wrap" is a mechanism to build dependencies that doesn't rely on git
> submodules and integrate external dependencies as subproject()s.
>
> This offers developpers a simpler way to build QEMU with missing system
> dependencies (ex, libslirp in my case), but also simplify the fallback build
> definition of dtc/libfdt.
Do we actually need this facility though ? We've already determined
that every platform we need has libslirp now, and IIUC Thomas determined
recently that dtc is also available everywhere we need it to be.
The main benefit is for developers: you have the source code of QEMU-related projects with the source tree. Code navigation, debugging, or various build tests are easier (compilation flags, static build etc). You don't have to "pollute" your system with (what could be) QEMU-specific libraries.
So why would we want to continue to special case these two libraries,
out of all the many many many other libraries we also have deps on.
They are more often updated, or developped with QEMU? For the reasons I listed, I would welcome more wrapped subprojects.