Re: [PATCH v2 35/76] target/m68k: Drop tcg_temp_free

[Peter Maydell]

On Mon, 27 Feb 2023 at 05:32, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Translators are no longer required to free tcg temporaries.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/m68k/translate.c | 181 ----------------------------------------
>  1 file changed, 181 deletions(-)
>
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index d7237b6a99..3055d2d246 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -138,7 +138,6 @@ static void delay_set_areg(DisasContext *s, unsigned 
> regno,
>  {
>      if (s->writeback_mask & (1 << regno)) {
>          if (give_temp) {
> -            tcg_temp_free(s->writeback[regno]);
>              s->writeback[regno] = val;
>          } else {
>              tcg_gen_mov_i32(s->writeback[regno], val);
> @@ -163,7 +162,6 @@ static void do_writebacks(DisasContext *s)
>          do {
>              unsigned regno = ctz32(mask);
>              tcg_gen_mov_i32(cpu_aregs[regno], s->writeback[regno]);
> -            tcg_temp_free(s->writeback[regno]);
>              mask &= mask - 1;
>          } while (mask);
>      }

I wondered briefly whether now temps are auto-freed the
complication of the 'give_temp' argument to this function could
be removed, but it was too unclear to me exactly what it was
doing. So never mind...

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM