|
From: | Thomas Huth |
Subject: | Re: [PATCH] test: Fix test-crypto-secret when compiling without keyring support |
Date: | Fri, 3 Mar 2023 13:47:40 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 |
On 01/03/2023 12.00, Juan Quintela wrote:
Linux keyring support is protected by CONFIG_KEYUTILS. Use CONFIG_SECRET_KEYRING. Signed-off-by: Juan Quintela <quintela@redhat.com> --- Previous version of this patch changed the meson build rules. Daniel told me that the proper fix was to change the #ifdef test. --- tests/unit/test-crypto-secret.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
This seems to cause failures in the CI: https://gitlab.com/thuth/qemu/-/jobs/3870672310#L1443 https://gitlab.com/thuth/qemu/-/jobs/3870672331#L2353 ../tests/unit/test-crypto-secret.c:29:10: fatal error: keyutils.h: No such file or directory 29 | #include <keyutils.h> | ^~~~~~~~~~~~ compilation terminated. And when building locally, I got: FAILED: tests/unit/test-crypto-secret tests/unit/test-crypto-secret.p/test-crypto-secret.c.o: In function `test_secret_keyring_expired_key': ../../devel/qemu/tests/unit/test-crypto-secret.c:194: undefined reference to `add_key' ../../devel/qemu/tests/unit/test-crypto-secret.c:197: undefined reference to `keyctl_set_timeout' ../../devel/qemu/tests/unit/test-crypto-secret.c:212: undefined reference to `keyctl_unlink' tests/unit/test-crypto-secret.p/test-crypto-secret.c.o: In function `test_secret_keyring_revoked_key': ../../devel/qemu/tests/unit/test-crypto-secret.c:169: undefined reference to `add_key' ../../devel/qemu/tests/unit/test-crypto-secret.c:172: undefined reference to `keyctl_revoke' ../../devel/qemu/tests/unit/test-crypto-secret.c:186: undefined reference to `keyctl_unlink' tests/unit/test-crypto-secret.p/test-crypto-secret.c.o: In function `test_secret_keyring_good': ../../devel/qemu/tests/unit/test-crypto-secret.c:141: undefined reference to `add_key' ../../devel/qemu/tests/unit/test-crypto-secret.c:155: undefined reference to `keyctl_unlink' collect2: error: ld returned 1 exit status Thomas
[Prev in Thread] | Current Thread | [Next in Thread] |