[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/6] Add the AEHD implementation.
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 6/6] Add the AEHD implementation. |
Date: |
Fri, 3 Mar 2023 11:15:43 +0100 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 |
On 3/3/23 03:26, Haitao Shan wrote:
Implement the AEHD accelerator including the AEHD AccelClass,
AccelCPUClass, AccelOpsClass.
Signed-off-by: Haitao Shan <hshan@google.com>
---
hw/i386/x86.c | 2 +-
include/exec/ram_addr.h | 2 -
include/sysemu/aehd.h | 87 ++
include/sysemu/hw_accel.h | 1 +
target/i386/aehd/aehd-accel-ops.c | 119 ++
target/i386/aehd/aehd-accel-ops.h | 22 +
target/i386/aehd/aehd-all.c | 1020 +++++++++++++++
target/i386/aehd/aehd-cpu.c | 150 +++
target/i386/aehd/aehd-cpu.h | 41 +
target/i386/aehd/aehd-stub.c | 22 +
target/i386/aehd/aehd.c | 1915 +++++++++++++++++++++++++++++
target/i386/aehd/aehd_i386.h | 26 +
target/i386/aehd/aehd_int.h | 2 +-
target/i386/aehd/meson.build | 4 +
target/i386/cpu.c | 12 +-
target/i386/cpu.h | 5 +-
target/i386/helper.c | 3 +
target/i386/meson.build | 1 +
18 files changed, 3428 insertions(+), 6 deletions(-)
I'm not going to review a 3000+ LoC patch, sorry.
1/ it is too big for my brain and I'm going to miss things
2/ it is likely duplicating KVM identical code; if so we
should refactor to use common code. In particular because
we can fix bugs once.
create mode 100644 target/i386/aehd/aehd-accel-ops.c
create mode 100644 target/i386/aehd/aehd-accel-ops.h
create mode 100644 target/i386/aehd/aehd-cpu.c
create mode 100644 target/i386/aehd/aehd-cpu.h
create mode 100644 target/i386/aehd/aehd-stub.c
create mode 100644 target/i386/aehd/aehd_i386.h
--- /dev/null
+++ b/target/i386/aehd/aehd-accel-ops.c
@@ -0,0 +1,119 @@
+/*
+ * QEMU AEHD support
+ *
+ * Copyright IBM, Corp. 2008
+ * Red Hat, Inc. 2008
+ *
+ * Authors:
+ * Anthony Liguori <aliguori@us.ibm.com>
+ * Glauber Costa <gcosta@redhat.com>
In various files you add in this series you use incorrect
author / (c). While you copy/paste their implementation,
they didn't authored this AEHD implementation (which is based
on their work).
- [PATCH 2/6] Add a few AEHD headers., (continued)
- [PATCH 2/6] Add a few AEHD headers., Haitao Shan, 2023/03/02
- [PATCH 3/6] Add the aehd-apic device type., Haitao Shan, 2023/03/02
- [PATCH 4/6] Add the aehd-ioapic device type., Haitao Shan, 2023/03/02
- [PATCH 5/6] Add the aehd-i8259 device type., Haitao Shan, 2023/03/02
- [PATCH 6/6] Add the AEHD implementation., Haitao Shan, 2023/03/02
- Re: [PATCH 6/6] Add the AEHD implementation.,
Philippe Mathieu-Daudé <=
- Re: [PATCH 1/6] Add the Android Emulator hypervisor driver (AEHD) accelerator., Michael S. Tsirkin, 2023/03/03
Re: [PATCH 1/6] Add the Android Emulator hypervisor driver (AEHD) accelerator., Haitao Shan, 2023/03/03